Re: [PATCH v2 06/06] staging: crypto: skein: rename files

From: Jake Edge
Date: Mon May 19 2014 - 09:45:19 EST


On Mon, 19 May 2014 12:09:59 +0400 Anton Saraev wrote:

> --- a/drivers/staging/skein/Makefile
> +++ b/drivers/staging/skein/Makefile
> @@ -4,10 +4,10 @@
> subdir-ccflags-y := -I$(src)/include/

as part of the rearranging of files, I think you want to get rid of
this include directory, move the files up to the main directory and
include them as "skein.h" (rather than <skein.h>).

Then this line can be removed from the Makefile.

> --- a/drivers/staging/skein/threefish1024Block.c
> +++ b/drivers/staging/skein/threefish_1024_block.c
> @@ -1,5 +1,5 @@
> #include <linux/string.h>
> -#include <threefishApi.h>
> +#include <threefish_api.h>

incidentally, none of the threefish_*_block.c files actually needs
linux/string.h ... there may be other files where that's true too, it
seems to have just gotten added everywhere ...

jake

--
Jake Edge - LWN - jake@xxxxxxx - http://lwn.net
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/