Re: [PATCH] block: mq flush: fix race between IPI handler and mq flush worker

[Christoph Hellwig]

On Mon, May 19, 2014 at 11:05:50PM +0800, Ming Lei wrote:
> Another simple fix is to disable ipi for flush request, but looks
> this one should be better.

I think the first thing is to bite the bullet and sort out and document
the various unions in struct request for real.

For example the first union has the call_single_data for the blk-mq
completions, while the second one has the ipi_list that is used by
the old blk-softirq code.

If we get this right with a single union that contains a struct for
each phase of the request we might find enough space to keep using
the current way.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/