Re: [PATCHSET 00/21] perf tools: Add support to accumulate hist periods (v9)

[Rodrigo Campos]

On Thu, Mar 20, 2014 at 02:36:25PM +0900, Namhyung Kim wrote:
> Hello,
> 
> This is a new attempt to implement cumulative hist period report.
> This work begins from Arun's SORT_INCLUSIVE patch [1] but I completely
> rewrote it from scratch.
> 
> This version depends on my previous percentage patchset [2] and output
> field patchset[3].  So please test this again although there's not
> much change in the series itself.
> 
> This patchset basically adds period in a sample to every node in the
> callchain.  A hist_entry now has an additional fields to keep the
> cumulative period if --children option is given on perf report.
> 
> I changed the option as a separate --children and added a new
> "Children" column (and renamed the default "Overhead" column into
> "Self").  The output will be sorted by children (cumulative) overhead
> for now.  It also adds 'overhead_children' field to -F/--fields option
> to be selected by user and it'll show you "N/A" if the cumulation is
> not supported (due to missing callchain).


Is there something I can help to have this merged ? As far as I tested, this
works fine here. Or is this ok, just waiting on the "perf report: Add -F option for
specifying output fields" patchset ?






Thanks a lot,

Rodrigo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/