Re: [PATCH] regulator: core: Fix the init of DT defined fixed regulators

From: Mark Brown
Date: Mon May 19 2014 - 12:18:55 EST


On Mon, May 19, 2014 at 05:25:56PM +0200, Alban Bedel wrote:

> Would checking that the regulator is at the voltage declared in the DT
> better? Or should I just add a pseudo set method to the regulator driver
> that only accept the current voltage? That could also be implemented at
> the core level using a default method for all regulators that have a get
> but no set method.

We already have code in the core to accept set_voltage() on fixed
voltage regulators - are you sure you're working with current code?
Otherwise fixing things to go through the standard set_voltage() path
would be OK. There should be no need to add a dummy function for
setting.

Attachment: signature.asc
Description: Digital signature