RE: [PATCH] x86/mce: Clear a useless global variable in mce.c

From: Luck, Tony
Date: Mon May 19 2014 - 18:06:44 EST


> I mean, does the machine even recover after some of the cores have gone
> into the weeds in #MC? Provided, of course, we don't have a no-way-out
> MCE and we can resume execution.

I doubt there is any hope for recovery if not all processors show up ... things
have to be already very broken for the machine check to be blocked.

> Or is the box so hammered that there's no turning back?

I think so.

> Concerning mce_entry, I don't care all that much - if it is really
> useful, you might slap a comment saying so and keep it, for all I care.

I'm OK with it going - but as I said before I'd like to see mce_callin printed
(so I can tell if just one cpu showed up, just the cpus from one socket, or
some other significant number).

-Tony