Re: [PATCH V2 mmots] fs/hfsplus/wrapper.c: replace shift loop by fls

[Andrew Morton]

On Fri, 16 May 2014 22:38:15 +0200 Fabian Frederick <fabf@xxxxxxxxx> wrote:

> Replace while blocksize;shift by fls -1
> 
> Suggested-By: Joe Perches <joe@xxxxxxxxxxx>
> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Fabian Frederick <fabf@xxxxxxxxx>
> ---
> v2: rebased on top of mmots
>     compiles without including bitops
> 
>  fs/hfsplus/wrapper.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/fs/hfsplus/wrapper.c b/fs/hfsplus/wrapper.c
> index 284c90f..8e8cf50d 100644
> --- a/fs/hfsplus/wrapper.c
> +++ b/fs/hfsplus/wrapper.c
> @@ -231,9 +231,7 @@ reread:
>  	if (blocksize < HFSPLUS_SECTOR_SIZE || ((blocksize - 1) & blocksize))
>  		goto out_free_backup_vhdr;
>  	sbi->alloc_blksz = blocksize;
> -	sbi->alloc_blksz_shift = 0;
> -	while ((blocksize >>= 1) != 0)
> -		sbi->alloc_blksz_shift++;
> +	sbi->alloc_blksz_shift = fls(blocksize) - 1;
>  	blocksize = min_t(u32, sbi->alloc_blksz, PAGE_SIZE);

fls() always makes my brain hurt.  ilog() is nicer?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/