Re: [PATCH 02/10] xhci: 'noxhci_port_switch' kernel parameter

[Greg KH]

On Thu, May 08, 2014 at 07:25:55PM +0300, Mathias Nyman wrote:
> From: Dan Williams <dan.j.williams@xxxxxxxxx>
> 
> Add a command line switch for disabling ehci port switchover.  Useful
> for working around / debugging xhci incompatibilities where ehci
> operation is available.
> 
> Reference: http://marc.info/?l=linux-usb&m=138920063001509&w=2
> 
> Cc: Sarah Sharp <sarah.a.sharp@xxxxxxxxxxxxxxx>
> Cc: Mathias Nyman <mathias.nyman@xxxxxxxxxxxxxxx>
> Cc: Holger Hans Peter Freyther <holger@xxxxxxxxxxxxxxxx>
> Suggested-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Dan Williams <dan.j.williams@xxxxxxxxx>
> Signed-off-by: Mathias Nyman <mathias.nyman@xxxxxxxxxxxxxxx>
> ---
>  Documentation/kernel-parameters.txt |  3 +++
>  drivers/usb/host/pci-quirks.c       | 15 +++++++++++++--
>  2 files changed, 16 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt
> index 4384217..fc3403114 100644
> --- a/Documentation/kernel-parameters.txt
> +++ b/Documentation/kernel-parameters.txt
> @@ -2251,6 +2251,9 @@ bytes respectively. Such letter suffixes can also be entirely omitted.
>  
>  	nox2apic	[X86-64,APIC] Do not enable x2APIC mode.
>  
> +	noxhci_port_switch
> +			[USB] Use EHCI instead of XHCI where available
> +

Ugh, I really don't like new command line options.

Especially one that isn't very well documented.  Why would someone want
to enable this?  What problem is it solving?  Can we detect this
automatically and do it for the user?  Is this just for prototype
hardware that has not shipped?  What hardware needs this?

I need a whole lot more documentation at the very least before I will
apply this.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/