Re: [STLinux Kernel] [PATCH 3/4] ARM: DT: STi: Add DT node for MiPHY365x

[Maxime Coquelin]

On 05/19/2014 05:51 PM, Lee Jones wrote:
> > > The MiPHY365x is a Generic PHY which can serve various SATA or PCIe
> > > devices. It has 2 ports which it can use for either; both SATA, both
> > > PCIe or one of each in any configuration.
> > >
> > > Cc: Srinivas Kandagatla <srinivas.kandagatla@xxxxxx>
> > > Acked-by: Mark Rutland <mark.rutland@xxxxxxx>
> > > Acked-by: Alexandre Torgue <alexandre.torgue@xxxxxx>
> > > Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>
> > > ---
> > >   arch/arm/boot/dts/stih416-b2020-revE.dts | 22 ++++++++++++++++++++++
> > >   arch/arm/boot/dts/stih416-b2020.dts      |  6 ++++++
> > >   arch/arm/boot/dts/stih416.dtsi           | 14 ++++++++++++++
> > >   3 files changed, 42 insertions(+)
> > >   create mode 100644 arch/arm/boot/dts/stih416-b2020-revE.dts
> > >
> > > diff --git a/arch/arm/boot/dts/stih416-b2020-revE.dts b/arch/arm/boot/dts/stih416-b2020-revE.dts
> > > new file mode 100644
> > > index 0000000..23fdaf7
> > > --- /dev/null
> > > +++ b/arch/arm/boot/dts/stih416-b2020-revE.dts
> > > @@ -0,0 +1,22 @@
> > > +/*
> > > + * Copyright (C) 2014 STMicroelectronics Limited.
> > > + * Author: Lee Jones <lee.jones@xxxxxxxxxx>
> > > + *
> > > + * This program is free software; you can redistribute it and/or modify
> > > + * it under the terms of the GNU General Public License version 2 as
> > > + * publishhed by the Free Software Foundation.
> > > + */
> > > +/dts-v1/;
> > > +#include "stih416.dtsi"
> > > +#include "stih41x-b2020.dtsi"
> > > +/ {
> > > +        model = "STiH416 B2020 REV-E";
> > > +	compatible = "st,stih416-b2020", "st,stih416";
> > > +
> > > +	soc {
> > > +		miphy365x_phy: miphy365x@fe382000 {
> > > +			st,pcie-tx-pol-inv;
> > > +			st,sata-gen = <3>;
> > > +		};
> > > +	};
> > > +};
> > Shouldn't this new board being added in a separate patch?
>
> I certainly can do that, but I don't think that it's necessary?

I think it is, as you introduce a new board.
Moreover, the miphy description being the same as in stih416-b2020.dts, 
so I don't understand why you introduce this board for this feature.


> > > diff --git a/arch/arm/boot/dts/stih416-b2020.dts b/arch/arm/boot/dts/stih416-b2020.dts
> > > index 276f28d..172f222 100644
> > > --- a/arch/arm/boot/dts/stih416-b2020.dts
> > > +++ b/arch/arm/boot/dts/stih416-b2020.dts
> > > @@ -13,4 +13,10 @@
> > >   	model = "STiH416 B2020";
> > >   	compatible = "st,stih416", "st,stih416-b2020";
> > >
> > > +	soc {
> > > +		miphy365x_phy: miphy365x@fe382000 {
> > > +			st,pcie-tx-pol-inv;
> > > +			st,sata-gen = <3>;
> > > +		};
> > > +	};
> > >   };
> > ...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/