Re: [PATCH v4 6/6] ARM: dts: STiH407: Add B2120 board support

[Olof Johansson]

On Tue, May 20, 2014 at 12:20 AM, Lee Jones <lee.jones@xxxxxxxxxx> wrote:
>> > B2120 HDK is the reference board for STiH407 SoC.
>> > It has the following characteristics:
>> >  - 1GB DDR3
>> >  - 8GB eMMC / SD-Card slot
>> >  - 32MB NOR Flash
>> >  - 1 x Gbit Ethernet
>> >  - 1 x USB 3.0 port
>> >  - 1 x Mini-PCIe
>> >  - 1 x SATA
>> >  - 1 x HDMI output
>> >  - 1 x HDMI input
>> >  - 1 x SPDIF
>> >
>> > This patch only introduces basic functionnalities, such as I2C and UART.
>> >
>> > Acked-by: Giuseppe Cavallaro <peppe.cavallaro@xxxxxx>
>> > Acked-by: Lee Jones <lee.jones@xxxxxxxxxx>
>> > Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@xxxxxx>
>> > Signed-off-by: Maxime Coquelin <maxime.coquelin@xxxxxx>
>> > ---
>> >  arch/arm/boot/dts/Makefile          |  3 +-
>> >  arch/arm/boot/dts/stih407-b2120.dts | 78 +++++++++++++++++++++++++++++++++++++
>> >  2 files changed, 80 insertions(+), 1 deletion(-)
>> >  create mode 100644 arch/arm/boot/dts/stih407-b2120.dts
>
> [...]
>
>> > +/ {
>> > +       model = "STiH407 B2120";
>> > +       compatible = "st,stih407", "st,stih407-b2120";
>>
>> This should go from specific to generic, so the order needs to be the other way.
>
> I did have a patch-set that changed all of these.  Wonder where that went!

Cool.

>
> [...]
>
>> > +       soc {
>> > +               sbc_serial0: serial@9530000 {
>> > +                       status = "okay";
>> > +               };
>>
>> You might want to consider reference-based syntax here instead, so you
>> don't have to mimic the hierarchy. That'd be (at the root level of the
>> file, below this secion:
>>
>> &sbc_serial0: {
>>         status = "okay";
>> };
>
> I'm personally not keen on this scheme.  It's sometimes helpful to know
> the hierarchy and I don't think it's a large overhead to format the
> subordinate DTS files in this way.
>
> Please consider not enforcing this.

Definitely not enforcing it, and I didn't use to like it either but it
has some real upsides.

In particular, it saves a lot of grief when you're changing something
like the unit-id of a node in .dtsi and forget to do the same update
in the dts.



-Olof
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/