Re: ååï Re: ååï [PATCH] arch/unicore32/kernel/setup.c: add generic 'screen_info' to avoid compiling failure

[Chen Gang]

On 05/21/2014 05:23 PM, çéæ wrote:
> 
> ----- Chen Gang <gang.chen.5i5j@xxxxxxxxx> åéï
>>
>> Yeah, I shall send patch v2 for it (within this week). And also thank
>> you for your review the other patches.
>>
>> BTW: I guess, it only leaves 2 kernel related issues for allmodconfig:
>>
>>  - one for 'find_first*', 'cpuc_coherent_kern_range' and 'pm_power_off'.
>>    I guess, we can export their symbol explicitly to fix this issue.
> 
> My suggestion:
>  find_first_* could export themselves in lib/find_first.c, so each archs can use it.
>    anyway, we can first add them in unicore32, and then make it a generic lib.
>  what's the problem with cpuc_coherent_kern_range? in fact, I'll remove it later.
>  pm_power_off need be exported.
> 

Thank you for your suggestions, and if you have already fixed them
(maybe you have done), please let me know. Or I shall send them within
this month.

The related error for 'cpu_coherent_kern_rage':

  ERROR: "__cpuc_coherent_kern_range" [drivers/misc/lkdtm.ko] undefined!

>>
>>  - the other for additional 'clk_*' which are needed when HAVE_CLK.
>>    I guess, just "copy/past" the other platforms' implementation is OK.
> 
> Maybe, COMMON_CLK should be selected. I'm not sure.
> 

I guess so, if you have already fix it (maybe you have done, I am not
quite familiar with version merging of Linux kernel), please let me
know. Or I shall process (continue think of) it within this month.


Thanks.
-- 
Chen Gang

Open, share, and attitude like air, water, and life which God blessed
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/