Re: [PATCH v8 0/2] Add support for the Allwinner A31 DMA Controller

[Arnd Bergmann]

On Wednesday 21 May 2014 17:55:51 Maxime Ripard wrote:
> On Wed, May 21, 2014 at 05:23:41PM +0200, Arnd Bergmann wrote:
> > On Wednesday 21 May 2014 17:15:54 Maxime Ripard wrote:
> > > Changes from v7:
> > >   - select DMA_OF, since we're only relying on DT
> > > 
> > 
> > I missed the discussion about this issue, but it seems wrong to me.
> > DMA_OF is currently enabled if we have both DMAENGINE and OF turned on.
> > 
> > If OF is disabled but DMA_OF gets selected by DMA_SUN6I, what happens?
> 
> Is that even possible with a multiplatform-based platform?

It's not possible for ARCH_SUNXI or any other that depends on
ARCH_MULTIPLATFORM. I just noticed that you have 'depends on ARCH_SUNXI',
so the 'select DMA_OF' statement is just redundant, not wrong.

However, if the driver was 'depends on ARCH_SUNXI || COMPILE_TEST' as many
others are nowadays, it would be a bug.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/