Re: [PATCHv5 09/10] DTS: ARM: OMAP3-N900: Add SSI support

From: Tony Lindgren
Date: Wed May 21 2014 - 18:08:26 EST


* Sebastian Reichel <sre@xxxxxxxxxx> [140521 14:51]:
> On Wed, May 21, 2014 at 12:45:28PM -0700, Tony Lindgren wrote:
>
> Right. The only documentation of the SSI module is existing
> code sent by Carlos / included in the maemo kernel.

That's probably better than any documentation though :)

> > > It's probably something with the sysc or idlemodes that
> > > keeps things from idling. Maybe wrong address? Or wrong
> > > flags? I'm pretty sure it was the first .dts patch out of
> > > these two as the second one alone did not apply.
> >
> > Hmm yeah below is probably how it should be, does this
> > work for you? With this fix applied and your ssi dts
> > patches n900 keeps hitting off-idle for me.
>
> I can confirm, that the N900 hits idle states when the DT
> patch and the hwmod patch is applied. I have not actually
> tested if it also works without your hwmod patch.
>
> There are still problems with the idle state if the driver is
> actually loaded (and I see 100% runtime pm usage in powertop),
> but that can be fixed later.
>
> Feel free to add Tested-by/Acked-By to the hwmod patch.

OK thanks for testing. I'll apply your dts changes as soon
as I have an ack from Paul on the hwmod changes. Probably
best to queue them together to avoid PM breaking.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/