Re: [PATCH 0/4] pagecache scanning with /proc/kpagecache

[Andrew Morton]

On Tue, 20 May 2014 22:26:30 -0400 Naoya Horiguchi <n-horiguchi@xxxxxxxxxxxxx> wrote:

> This patchset adds a new procfs interface to extrace information about
> pagecache status. In-kernel tool tools/vm/page-types.c has already some
> code for pagecache scanning without kernel's help, but it's not free
> from measurement-disturbance, so here I'm suggesting another approach.

I'm not seeing much explanation of why you think the kernel needs this.
The overall justification for a change is terribly important so please
do spend some time on it.

As I don't *really* know what the patch is for, I can't comment a lot
further, but...


A much nicer interface would be for us to (finally!) implement
fincore(), perhaps with an enhanced per-present-page payload which
presents the info which you need (although we don't actually know what
that info is!).

This would require open() - it appears to be a requirement that the
caller not open the file, but no reason was given for this.

Requiring open() would address some of the obvious security concerns,
but it will still be possible for processes to poke around and get some
understanding of the behaviour of other processes.  Careful attention
should be paid to this aspect of any such patchset.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/