Re: [V6 01/11] perf: Add PERF_SAMPLE_BRANCH_COND

[Anshuman Khandual]

On 05/21/2014 05:00 PM, Peter Zijlstra wrote:
> On Wed, May 21, 2014 at 03:29:46PM +0530, Anshuman Khandual wrote:
>> This patch introduces new branch filter PERF_SAMPLE_BRANCH_COND which
>> will extend the existing perf ABI. Various architectures can provide
>> this functionality with either with HW filtering support (if present)
>> or with SW filtering of captured branch instructions.
> 
> The Changelog fails to mention what _this_ functionality is.
> 

Peter,

Hope this new change log below makes more sense.

---------------------------------------------------------------------------
commit af75191bb7ad36cba7d75c2741c93dfbdaf09da3
Author: Anshuman Khandual <khandual@xxxxxxxxxxxxxxxxxx>
Date:   Mon Jul 22 12:22:27 2013 +0530

    perf: Add new conditional branch filter PERF_SAMPLE_BRANCH_COND
    
    This patch introduces new branch filter PERF_SAMPLE_BRANCH_COND which
    will extend the existing perf ABI. This will filter branches which are
    conditional. Various architectures can provide this functionality either
    with HW filtering support (if present) or with SW filtering of captured
    branch instructions.
    
    Signed-off-by: Anshuman Khandual <khandual@xxxxxxxxxxxxxxxxxx>
    Reviewed-by: Stephane Eranian <eranian@xxxxxxxxxx>
    Reviewed-by: Andi Kleen <ak@xxxxxxxxxxxxxxx>

diff --git a/include/uapi/linux/perf_event.h b/include/uapi/linux/perf_event.h
index 853bc1c..696f69b4 100644
--- a/include/uapi/linux/perf_event.h
+++ b/include/uapi/linux/perf_event.h
@@ -163,8 +163,9 @@ enum perf_branch_sample_type {
 	PERF_SAMPLE_BRANCH_ABORT_TX	= 1U << 7, /* transaction aborts */
 	PERF_SAMPLE_BRANCH_IN_TX	= 1U << 8, /* in transaction */
 	PERF_SAMPLE_BRANCH_NO_TX	= 1U << 9, /* not in transaction */
+	PERF_SAMPLE_BRANCH_COND		= 1U << 10, /* conditional branches */
 
-	PERF_SAMPLE_BRANCH_MAX		= 1U << 10, /* non-ABI */
+	PERF_SAMPLE_BRANCH_MAX		= 1U << 11, /* non-ABI */
 };
 
 #define PERF_SAMPLE_BRANCH_PLM_ALL \

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/