Re: [PATCH 03/03] staging: board: kzm9d: Board staging support for emxx_udc

[Magnus Damm]

Hi Geert,

On Thu, May 22, 2014 at 6:19 PM, Geert Uytterhoeven
<geert@xxxxxxxxxxxxxx> wrote:
> Hi Magnus,
>
> On Thu, May 22, 2014 at 10:54 AM, Magnus Damm <magnus.damm@xxxxxxxxx> wrote:
>> Add staging board support for the KZM9D board and add
>> an emxx_udc platform device to allow in-tree continous
>> development of the driver on the KZM9D board.
>>
>> When DT bindings are ready for the emxx_udc driver then
>> the platform device in the KZM9D staging board code can
>> easily be removed. Until then we use platform devices
>> to continously improve the driver and integration code.
>
> Nice!

Thanks, I hope it can turn into something useful!

>>  drivers/staging/Kconfig        |    2 ++
>>  drivers/staging/Makefile       |    1 +
>>  drivers/staging/board/Kconfig  |    7 +++++++
>>  drivers/staging/board/Makefile |    1 +
>>  drivers/staging/board/board.h  |   17 +++++++++++++++++
>>  drivers/staging/board/kzm9d.c  |   18 ++++++++++++++++++
>>  6 files changed, 46 insertions(+)
>
> As you're adding infrastructure and a first user, I think this should
> be split in two patches:
>   - Introduction of drivers/staging/board infrastructure,
>   - Addition of kzm9d board support.

I agree!

>> --- /dev/null
>> +++ work/drivers/staging/board/Kconfig  2014-05-22 15:31:58.000000000 +0900
>> @@ -0,0 +1,7 @@
>> +config STAGING_BOARD
>> +       boolean "Staging Board Support"
>> +       help
>> +         Select to enable per-board staging support code.
>> +
>> +         If in doubt, say N here.
>> +
>
> No board-specific Kconfig symbols, so the actual individual board
> support itself is
> always compiled-in (but see below)?

Yes, the user has a single switch to flip at this point.

>> --- /dev/null
>> +++ work/drivers/staging/board/Makefile 2014-05-22 15:31:58.000000000 +0900
>> @@ -0,0 +1 @@
>> +obj-$(CONFIG_ARCH_SHMOBILE_MULTI)      += kzm9d.o
>
> Ah, it's included in all shmobile multi-platform kernels.

Correct!

> What about testing for CONFIG_ARCH_EMEV2 instead of
> CONFIG_ARCH_SHMOBILE_MULTI?

That is quite fine with me.

> Or adding a KZM9D-specific Kconfig symbol to .../board/Kconfig?

Yeah, we could do that but my gut feeling is that it is better and
easier to just keep it simple. I'm happy to adjust in any direction
here though, so whatever makes people happy...!

Thanks for your feedback!

/ magnus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/