Re: [PATCH v2 0/7] drm/tegra: Convert to master/component framework
From: Thierry Reding
Date: Thu May 22 2014 - 05:58:47 EST
On Tue, May 13, 2014 at 05:30:43PM +0200, Thierry Reding wrote:
> From: Thierry Reding <treding@xxxxxxxxxx>
>
> Hi,
>
> This series converts the Tegra DRM driver to the master/component
> framework. The length of the series and the list of people in Cc is
> mostly due to the fact that Tegra has some special requirements as
> opposed to other drivers and therefore requires some changes outside
> of DRM.
>
> Patch 1 introduces a helper function that can be used by new DRM drivers
> that don't rely on legacy userspace ABIs. It allows them to register DRM
> devices much more easily and without much of the midlayer that currently
> exists in the DRM subsystem.
>
> Patches 2 and 3 make some changes to the master/component framework
> which are necessary to convert Tegra DRM to use it. All current users of
> the API have been converted as part of this patch. Note that at the same
> time the drivers are converted to no longer use drm_platform_init() in
> favour of the drm_set_unique() from patch 1 in conjunction with
> drm_dev_alloc() and drm_dev_register(). I would've liked to avoid such
> invasive changes in a single patch, but unfortunately I couldn't think
> of a way how to do that. I'm open to suggestions.
>
> Patch 4 adds a new interface framework that supplements the master/
> component framework and can be used in situations where there is no
> struct device * that a driver can bind to.
>
> The Tegra DRM driver is converted to using the master/component
> framework in patch 5 using the above four patches.
>
> Finally patches 6 and 7 add some documentation about the new way of
> registering DRM devices that don't need legacy support.
>
> Each patch has a somewhat more elaborate description of why it is needed
> or what problem it solves. The patchset applies on top of linux-next.
>
> I welcome any questions or comments you might have.
>
> Thierry
>
> Thierry Reding (7):
> drm: Introduce drm_set_unique()
> drivers/base: Allow driver-data to be attached to a master
> drivers/base: Allow multiple masters per device
> drivers/base: Add interface framework
> drm/tegra: Convert to master/component framework
> drm: Add device registration documentation
> drm: Document how to register devices without struct drm_bus
Greg, Russell,
Any comments on this? I've been blocking a bunch of patches in the hopes
of getting this merged since it allows the Tegra DRM driver to be
cleaned up a great deal, but if nobody's going to look at or comment on
this I'll abandon this series and keep using the custom solution we've
had for a while now.
Thierry
Attachment:
pgpBMfps7oJaI.pgp
Description: PGP signature