Re: [Patch v5 3/7] mfd: ti-keystone-devctrl: add bindings for device state control

From: Ivan Khoronzhuk
Date: Thu May 22 2014 - 10:34:06 EST



On 05/22/2014 05:14 PM, Lee Jones wrote:
Why do I only have this patch? Where is the rest of the set? Also,
it's on v5 and I don't recall seeing the other 4 versions?

It's strange I've sent whole series on

linux-kernel@xxxxxxxxxxxxxxx
linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
linux-doc@xxxxxxxxxxxxxxx
devicetree@xxxxxxxxxxxxxxx

v4 is also was sent to lists in question:
https://lkml.org/lkml/2014/5/21/359

The Keystone II devices have a set of registers that are used to control
the status of its peripherals. This node is intended to allow access to
this functionality.

Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@xxxxxx>
---
.../devicetree/bindings/mfd/ti-keystone-devctrl.txt | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
create mode 100644 Documentation/devicetree/bindings/mfd/ti-keystone-devctrl.txt

diff --git a/Documentation/devicetree/bindings/mfd/ti-keystone-devctrl.txt b/Documentation/devicetree/bindings/mfd/ti-keystone-devctrl.txt
new file mode 100644
index 0000000..35f7a66
--- /dev/null
+++ b/Documentation/devicetree/bindings/mfd/ti-keystone-devctrl.txt
@@ -0,0 +1,19 @@
+* Device tree bindings for Texas Instruments keystone device state control
+
+The Keystone II devices have a set of registers that are used to control
+the status of its peripherals. This node is intended to allow access to
+this functionality.
+
+Required properties:
+
+- compatible: "ti,keystone-devctrl", "syscon"
+
+- reg: contains offset/length value for pll controller
+ registers space.
Why have you tabbed out all that way?

I'll correct


+Example:
+
+devctrl: device-state-control {
This node needs an address:

devctrl: device-state-control@02620000 {

Thanks!
I will correct

+ compatible = "ti,keystone-devctrl", "syscon";
+ reg = <0x02620000 0x1000>;
+};

--
Regards,
Ivan Khoronzhuk

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/