Re: [PATCH] dt/sparc: Introduce the use of the managed version of kzalloc

[Julia Lawall]

On Thu, 22 May 2014, Dmitry Torokhov wrote:

> Hi Himangi,
>
> On Fri, May 23, 2014 at 01:04:30AM +0530, Himangi Saraogi wrote:
> > This patch moves data allocated using kzalloc to managed data allocated
> > using devm_kzalloc and cleans now unnecessary kfrees in probe and remove
> > functions. Also the unnecessary labels are done away with.
>
> Please no more partial devm conversions. I am not interested in patches
> that change only 1 resource to be managed and leaving the rest as is.
>
> If you want to do devm conversion please do it if you convert all (or at
> least majority) of resource handling to managed resources.

Sorry, I don't think we are clear on what is wanted.  Himangi's patches
convert everything where a devm function is already available (to our
knowledge).  Do you prefer that new devm functions be introduced?  On the
one hand, that is perhaps useful from a safety point of view.  On the
other hand, it could lead to a huge number of rarely used devm functions
that no one knows about and to a lot of code diversity.  So I don't know
what is the good solution.

thanks,
julia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/