Re: [PATCH] ARM: imx: introduce function imx_free_mx3_camera
From: Philippe Rétornaz
Date: Fri May 23 2014 - 02:51:00 EST
Hi Uwe
Le 22/05/2014 20:10, Uwe Kleine-König a écrit :
[...]
Today all imx machines should get their devices from an oftree, so
the various functions to add devices started to bitrot. Moreover
there is no reason to remove a device once it was successfully
added.
Note that platform_device_register_full has the same problem (i.e.
pdev->dev.dma_mask isn't freed when the last reference to a device
is dropped.) You'd do a better deed if you picked up
http://thread.gmane.org/gmane.linux.kernel/1613364/focus=1635995
instead of fixing dead code.
I would like to object that all imx machine should now boot from devicetree.
mx31moboard is still used and still get its kernel updated.
It has never booted from devicetree, and IIRC the "deal" when devicetree
was enforced on ARM was that all previous boards where still supported
and would not get removed.
So please don't kick us out of the kernel so fast :)
Thanks !
Philippe
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/