Re: [PATCH v2 4/4] ARM: debug: qcom: add UART addresses to Kconfig help

[Matthias Brugger]

2014-05-23 17:12 GMT+02:00 Georgi Djakov <gdjakov@xxxxxxxxxx>:
> Add information about the APQ8084 debug UART physical and virtual
> addresses in the DEBUG_QCOM_UARTDM Kconfig help section.
> Requires: https://lkml.org/lkml/2014/4/14/312
>
> Signed-off-by: Georgi Djakov <gdjakov@xxxxxxxxxx>
> ---
>  arch/arm/Kconfig.debug |    1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
> index 40ee328..e71723d 100644
> --- a/arch/arm/Kconfig.debug
> +++ b/arch/arm/Kconfig.debug
> @@ -376,6 +376,7 @@ choice
>                   their output to the serial port on Qualcomm devices.
>
>                   ARCH      DEBUG_UART_PHYS   DEBUG_UART_BASE
> +                 APQ8084   0xf995e000        0xfa75e000
>                   MSM8X60   0x19c40000        0xf0040000
>                   MSM8960   0x16440000        0xf0040000
>                   MSM8974   0xf991e000        0xfa71e000

You don't have any uart defined in your dts. You should add them
before any adding low level debug support.
Otherwise there might be problems in booting a multi-platform kernel.

Regards,
Matthias

> --
> 1.7.9.5
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel



-- 
motzblog.wordpress.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/