Re: [PATCH v2 1/2] irqchip: add Broadcom Set Top Box Level-2 interrupt controller

[Florian Fainelli]

2014-05-22 18:51 GMT-07:00 Thomas Gleixner <tglx@xxxxxxxxxxxxx>:
> On Thu, 22 May 2014, Florian Fainelli wrote:
>> +static void brcmstb_l2_intc_irq_handle(unsigned int irq, struct irq_desc *desc)
>> +{
>> +     struct brcmstb_l2_intc_data *b = irq_desc_get_handler_data(desc);
>> +     struct irq_chip *chip = irq_get_chip(irq);
>
> irq_desc_get_chip() is what you want here. irq_get_chip() is doing a
> full lookop of desc, which is silly as you have desc already.

Thanks, is there anything else that needs fixing before I submit a v3? Thanks!
-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/