Re: [PATCH 4/4] lib/debugobjects.c: code clean-up

[Josh Triplett]

On Sat, May 24, 2014 at 03:08:06PM +0200, Fabian Frederick wrote:
> Fix some checkpatch warnings.
> 
> Cc: Josh Triplett <josh@xxxxxxxxxxxxxxxx>
> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Fabian Frederick <fabf@xxxxxxxxx>

Some of these make sense, one of them does not.  Comments below.

Also, please explicitly note the checkpatch warnings you fixed, not just
"Fix some checkpatch warnings.".

> --- a/lib/debugobjects.c
> +++ b/lib/debugobjects.c
[...]
> @@ -415,7 +415,8 @@ int debug_object_activate(void *addr, struct debug_obj_descr *descr)
>  			debug_print_object(obj, "activate");
>  			state = obj->state;
>  			raw_spin_unlock_irqrestore(&db->lock, flags);
> -			ret = debug_object_fixup(descr->fixup_activate, addr, state);
> +			ret = debug_object_fixup(descr->fixup_activate,
> +						 addr, state);

This does not seem like a worthwhile improvement.  Please don't blindly
listen to checkpatch, especially regarding line lengths.

- Josh Triplett
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/