Re: [PATCH v7 1/6] SP800-90A Deterministic Random Bit Generator

[Stephan Mueller]

Am Samstag, 24. Mai 2014, 05:10:07 schrieb Herbert Xu:

Hi Herbert,

> Stephan Mueller <smueller@xxxxxxxxxx> wrote:
> > +       memset(&drbg_algs[i], 0, sizeof(struct crypto_alg));
> > +       if (pr) {
> > +               memcpy(drbg_algs[i].cra_name, "drbg(pr(", 8);
> > +               memcpy(drbg_algs[i].cra_driver_name, "drbg_pr_", 8);
> > +               pos = 8;
> 
> You shouldn't use the brackets here since this not a real template.
> Just use one name for both cra_name and cra_driver_name.

Thanks for the hint: I would use the name specified for cra_driver_name also 
for cra_name
> 
> Cheers,


Ciao
Stephan
-- 
| Cui bono? |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/