Re: [PATCH v3 13/13] mmc: mmci: Add Qcom specific pio_read function.

[Srinivas Kandagatla]

On 26/05/14 15:34, Ulf Hansson wrote:
> This is hot path.
>
> As I suggested for the readl and writel wrapper functions, I think it
> would be better to use a function pointer in the struct mmci host,
> which you set up in the probe phase. That means the variant data don't
> need to be checked each an every time this function gets invoked.
>
> > >+
> > >                 if (status & MCI_TXACTIVE)
> > >                         len = mmci_pio_write(host, buffer, remain, status);
> So no changes needed for pio_write at this point? Or those will come later?

Yes, that sounds like more sensible approach to me. I will do this 
change in next version.

Thanks,
srini
> > >
> > >--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/