Re: [PATCH 1/3] driver core/platform: don't leak memory allocated for dma_mask

From: Dan Carpenter
Date: Mon May 26 2014 - 15:32:09 EST


On Mon, May 26, 2014 at 06:41:21PM +0200, Emil Goode wrote:
> diff --git a/drivers/base/platform.c b/drivers/base/platform.c
> index 9e9227e..dd1fa07 100644
> --- a/drivers/base/platform.c
> +++ b/drivers/base/platform.c
> @@ -166,6 +166,7 @@ EXPORT_SYMBOL_GPL(platform_add_devices);
> struct platform_object {
> struct platform_device pdev;
> char name[1];
> + u64 dma_mask;
> };

Heh. No this doesn't work as patch #1. You have to have name at the
end of the struct.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/