Re: [PATCH v3] clk: shmobile: mstp: Fix the is_enabled() operation

From: Magnus Damm
Date: Mon May 26 2014 - 21:02:54 EST


On Fri, May 23, 2014 at 3:02 AM, Geert Uytterhoeven
<geert+renesas@xxxxxxxxx> wrote:
> From: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx>
>
> The MSTP[SC]R registers have clock stop bits, not clock enable bits. The
> bit value should thus be inverted in the is_enabled() operation.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> Cc: Mike Turquette <mturquette@xxxxxxxxxx>
> ---
> v3:
> - This depends on commit 3c90c55dcde745bed81f6447f24ba96bda43d984
> ("drivers: sh: compile drivers/sh/pm_runtime.c if
> ARCH_SHMOBILE_MULTI"), which has entered mainline in v3.15-rc6.

Hi Geert,

Thanks for resubmitting this fix. Do you intend to get this included
in v3.15 (seems unlikely) or is your target v3.16?

Cheers,

/ magnus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/