Re: [PATCH] MIPS: cavium-octeon: remove checks for CONFIG_CAVIUM_GDB

[Ralf Baechle]

On Fri, May 23, 2014 at 11:37:01PM +0200, Andreas Herrmann wrote:

> > void __init smp_cpus_done(unsigned int max_cpus)
> > {
> > - 	mp_ops->cpus_done();
> > + 	if (cpus_done)
> > + 		mp_ops->cpus_done();
> > }
> > 
> > which would make a NULL cpus_done function pointer safe and allow empty definitions
> > to be removed.
> 
> I'd prefer this solution over complete removal of the hook.

In the end that's what I just did.

Which leaves smp_cpus_done() empty.  I think I'm going to put in a
function to print a summary of CPUs booted but that's for another
patch.

  Ralf
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/