Re: [PATCH] usb: pci-quirks: do not access OHCI_FMINTERVAL register on ULI hw

[Alan Stern]

On Tue, 27 May 2014, Nikita Yushchenko wrote:

> This access causes hang on Freescale P2020DS board (that has OHCI
> provided by ULI 1533 chip).

Which access, the read or the write?

> Since preserving OHCI_FMINTERVAL was originally done only for NVIDIA
> hardware and only later (in c6187597) was turned unconditional, and

Correction: Preserving OHCI_FMINTERVAL was originally done for all 
controllers that needed to be reset.  It just so happened that NVIDIA 
was the only one that got reset.  In c6187597 the reset became 
unconditional, so fminterval was preserved for all hardware.

> c6187597 commit message again mentions only NVIDIA, I think it should be
> safe to disable preserving OHCI_FMINTERVAL if device vendor is ULI.
> 
> Signed-off-by: Nikita Yushchenko <nyushchenko@xxxxxxxxxxxxx>

It looks like you haven't read ohci_shutdown() and ohci_run() in 
drivers/usb/host/ohci-hcd.c.  They both access the fminterval register, 
and this patch doesn't change them.

So I don't see why this patch should make any difference to the 
system's operation.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/