Re: [PATCH] remove duplicated comment and fix brace placement in drivers/staging/comedi/drivers/addi-data/hwdrv_acpi3501.c

[Dan Carpenter]

The subject should be:

[PATCH] Staging: comedi: addi-data: <short title. clean up else statement>



On Tue, May 27, 2014 at 02:17:35PM +0000, Marcin Kostrzewa wrote:
> Signed-off-by: Marcin Kostrzewa <marckostrzewa@xxxxxxxxx>
> ---
>  drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c
> index 20e89b0..8add8d8 100644
> --- a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c
> +++ b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c
> @@ -104,9 +104,7 @@ static int apci3501_write_insn_timer(struct comedi_device *dev,
>  			outl(ul_Command1, dev->iobase + APCI3501_TIMER_CTRL_REG);
>  		}
>  
> -		else if (data[1] == 0)	/* Stop The Watchdog */
> -		{
> -			/* Stop The Watchdog */
> +		else if (data[1] == 0) { /* Stop The Watchdog */


While you're at it, could you also move it like this:

		} else if (data[1] == 0) { /* Stop The Watchdog */

(I wouldn't have asked you to do this, except that you need to resend
anyway with a fixed subject line).

regards,
dan carpenter

>  			ul_Command1 = inl(dev->iobase + APCI3501_TIMER_CTRL_REG);
>  			ul_Command1 = ul_Command1 & 0xFFFFF9FEUL;
>  			outl(0x0, dev->iobase + APCI3501_TIMER_CTRL_REG);
> -- 
> 1.9.2
> 
> _______________________________________________
> devel mailing list
> devel@xxxxxxxxxxxxxxxxxxxxxx
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/