Re: 3.15-rc6 build / link failed fs/built-in mb_cache_entry problems

From: Randy Dunlap
Date: Tue May 27 2014 - 18:51:45 EST


On 05/27/2014 03:22 PM, Thavatchai Makphaibulchoke wrote:
> On 05/26/2014 11:04 PM, Randy Dunlap wrote:
>> On 05/26/2014 11:17 AM, werner wrote:
>> @tmac: can mbcache.c #include <linux/log2.h> and use ilog2(NR_BG_LOCKS)
>> instead of using __builtin_log2(NR_BG_LOCKS) ?
>> (ref. commit ID 1f3e55fe02d12213f87869768aa2b0bad3ba9a7d)
>>
>
> I don't see any problem with that, unless somebody else has any concern. Please let me know if you'd like me to submit the change.

I'd say yes since some gcc version(s) don't seem to support __builtin_log2().

--
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/