Re: [PATCH] pwm: i.MX: Cleanup indentation for register definitions

From: Lothar WaÃmann
Date: Wed May 28 2014 - 05:56:45 EST


Hi,

Liu Ying wrote:
> This patch contains no logic change to cleanup indentation
> for register definitions only.
>
> Cc: Thierry Reding <thierry.reding@xxxxxxxxx>
> Cc: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
> Cc: Shawn Guo <shawn.guo@xxxxxxxxxxxxx>
> Cc: Lothar WaÃmann <LW@xxxxxxxxxxxxxxxxxxx>
> Cc: linux-pwm@xxxxxxxxxxxxxxx
> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> Signed-off-by: Liu Ying <Ying.Liu@xxxxxxxxxxxxx>
> ---
> drivers/pwm/pwm-imx.c | 26 +++++++++++++-------------
> 1 file changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/pwm/pwm-imx.c b/drivers/pwm/pwm-imx.c
> index cc47733..0784554 100644
> --- a/drivers/pwm/pwm-imx.c
> +++ b/drivers/pwm/pwm-imx.c
> @@ -21,24 +21,24 @@
>
> /* i.MX1 and i.MX21 share the same PWM function block: */
>
> -#define MX1_PWMC 0x00 /* PWM Control Register */
> -#define MX1_PWMS 0x04 /* PWM Sample Register */
> -#define MX1_PWMP 0x08 /* PWM Period Register */
> +#define MX1_PWMC 0x00 /* PWM Control Register */
> +#define MX1_PWMS 0x04 /* PWM Sample Register */
> +#define MX1_PWMP 0x08 /* PWM Period Register */
>
> -#define MX1_PWMC_EN (1 << 4)
> +#define MX1_PWMC_EN (1 << 4)
>
> /* i.MX27, i.MX31, i.MX35 share the same PWM function block: */
>
> -#define MX3_PWMCR 0x00 /* PWM Control Register */
> -#define MX3_PWMSAR 0x0C /* PWM Sample Register */
> -#define MX3_PWMPR 0x10 /* PWM Period Register */
> -#define MX3_PWMCR_PRESCALER(x) (((x - 1) & 0xFFF) << 4)
> -#define MX3_PWMCR_DOZEEN (1 << 24)
> -#define MX3_PWMCR_WAITEN (1 << 23)
> +#define MX3_PWMCR 0x00 /* PWM Control Register */
> +#define MX3_PWMSAR 0x0C /* PWM Sample Register */
> +#define MX3_PWMPR 0x10 /* PWM Period Register */
> +#define MX3_PWMCR_PRESCALER(x) (((x - 1) & 0xFFF) << 4)
^
You could also add the missing () around the macro argument when you
are changing this line anyway.


Lothar WaÃmann
--
___________________________________________________________

Ka-Ro electronics GmbH | PascalstraÃe 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
GeschÃftsfÃhrer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996

www.karo-electronics.de | info@xxxxxxxxxxxxxxxxxxx
___________________________________________________________
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/