Re: blk-mq: refactor request allocation

[Jens Axboe]

On 2014-05-27 23:19, Christoph Hellwig wrote:
> On Tue, May 27, 2014 at 02:58:08PM -0600, Jens Axboe wrote:
> > On 05/27/2014 12:59 PM, Christoph Hellwig wrote:
> > > This series streamlines the request allocation path.
> >
> > Series looks innocuous enough to me, but it's about a 1.5% performance
> > drop here with an actual device. These tests are very stable, anything
> > over ~0.1% is definitely outside of noise. I repeated and rebooted a few
> > times and tested both, it's persistent. No smoking guns in the profile.
>
> Can you do a bisect to narrow it down to one of the patches?

Did bisect and even one-by-one, and now it doesn't show up of course. 
The nvme branch was rebased on top of a new base since yesterday, so it 
could just be layout weirdness from the previous one.

So I think we can call it fine, I'll apply it.

--
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/