Re: [PATCH] scsi/NCR5380: dprintk macro

From: Christoph Hellwig
Date: Wed May 28 2014 - 11:53:44 EST


On Thu, May 29, 2014 at 12:43:43AM +1000, Finn Thain wrote:
>
> This is the delta between the two submissions:
> [PATCH 00/12] scsi/NCR5380: fix debugging macros and #include structure
> and
> [PATCH v2 00/12] scsi/NCR5380: fix debugging macros and #include structure
>
> The macro definition changes were discussed on the mailing list during
> review. The idea is to get the compiler to check the parameters of
> disabled printk() calls so that the debugging code doesn't rot again.
>
> Signed-off-by: Finn Thain <fthain@xxxxxxxxxxxxxxxxxxx>

Thanks a lot Finn!

> I know the whitespace is wrong throughout these drivers but when I put
> this patch series together it seemed best to defer the whitespace cleanup.
>(I still intend to do that cleanup.)

Yes, I ignored the whitespace warnings in the debug macro cleanups. I
fixed them up for the "newly" added code in the sun3 driver merge.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/