Re: linux-next: build failure after merge of the tty tree

[Barry Song]

2014-05-29 20:18 GMT+08:00 Barry Song <Barry.Song@xxxxxxx>:
> From: Stephen Rothwell [sfr@xxxxxxxxxxxxxxxx]
> Sent: Thursday, May 29, 2014 15:28
> To: Greg KH
> Cc: linux-next@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Qipan Li; Barry Song
> Subject: linux-next: build failure after merge of the tty tree
>
> Hi Greg,
>
> After merging the tty tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
>
> drivers/tty/serial/sirfsoc_uart.c: In function 'sirfsoc_uart_rx_dma_complete_tl':
> drivers/tty/serial/sirfsoc_uart.c:707:2: error: 'struct uart_port' has no member named 'rx_lock'
>
> Caused by commit 07d410e06463 ("serial: sirf: fix spinlock deadlock
> issue").  Did anyone even build test this? Much less test that it fixed
> the deadlock ... :-(
>

Stephen, it is my fault. qipan did a strange mis-operation when he
prepared this patch and i didn't double-confirm it.
but the patch did have been tested on real hardware to fix the
deadlock issue. it is not a patch without test.

the build issue has been fixed in another thread: [PATCH tty-next]
serial: sirf: Fix compilation failure
https://lkml.org/lkml/2014/5/29/476

i am very sorry for this as the related platform maintainer. i didn't
control this well and missed to do a double build for this. again, i
am very sorry!

> I have used the tty tree from next-20140528 for today.
> --
> Cheers,
> Stephen Rothwell                    sfr@xxxxxxxxxxxxxxxx
>

-barry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/