Re: [PATCH v3] pinctrl: to avoid duplicated calling enable_pinmux_setting for a pin

[Stephen Warren]

On 05/25/2014 08:43 PM, fwu@xxxxxxxxxxx wrote:
> From: Fan Wu <fwu@xxxxxxxxxxx>
> 
> What the patch did:
> 1.To call pinmux_disable_setting ahead of pinmux_enable_setting in each time of
>   calling pinctrl_select_state
> 2.Remove the HW disable operation in in pinmux_disable_setting function.
...

This commit description is way too long for such a simple change. A much
shorter summary would be better.

> Signed-off-by: Fan Wu <fwu@xxxxxxxxxxx>
> Signed-off-by: Stephen Warren <swarren@xxxxxxxxxx>

I'm pretty sure I never signed off on this patch. How come my s-o-b line
is there?

This patch still doesn't remove ops->disable from the struct pinmux_ops,
nor any of its implementations. Shouldn't it?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/