Re: [RFC 2/2] x86_64: expand kernel stack to 16K

From: Dave Jones
Date: Thu May 29 2014 - 20:07:25 EST


On Fri, May 30, 2014 at 09:53:08AM +1000, Dave Chinner wrote:

> That sounds like a plan. Perhaps it would be useful to add a
> WARN_ON_ONCE(stack_usage > 8k) (or some other arbitrary depth beyond
> 8k) so that we get some indication that we're hitting a deep stack
> but the system otherwise keeps functioning. That gives us some
> motivation to keep stack usage down but isn't a fatal problem like
> it is now....

We have check_stack_usage() and DEBUG_STACK_USAGE for this.
Though it needs some tweaking if we move to 16K

I gave it a try yesterday, and noticed a spew of noisy warnings as soon
as I gave it a workload to chew on. (Moreso than usual with 8K stacks)

Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/