Re: [PATCH 4/4] extcon: arizona: Correct typo to disable regulation for button detection
From: Chanwoo Choi
Date: Thu May 29 2014 - 21:31:36 EST
On 05/30/2014 12:27 AM, Charles Keepax wrote:
> We can use the bypass mode on the MICVDD reg for button detection, as
> the comment in the code states, however the code was mistakenly
> disabling bypass. This patch corrects this and allows bypass mode during
> button detection.
>
> Signed-off-by: Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
> ---
> drivers/extcon/extcon-arizona.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c
> index c1c8647..b2770aa 100644
> --- a/drivers/extcon/extcon-arizona.c
> +++ b/drivers/extcon/extcon-arizona.c
> @@ -826,7 +826,7 @@ static void arizona_micd_detect(struct work_struct *work)
> ret);
>
> /* Don't need to regulate for button detection */
> - ret = regulator_allow_bypass(info->micvdd, false);
> + ret = regulator_allow_bypass(info->micvdd, true);
> if (ret != 0) {
> dev_err(arizona->dev, "Failed to bypass MICVDD: %d\n",
> ret);
>
Applied.
Thanks,
Chanwoo Choi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/