Re: [PATCH v4 2/3] mfd: intel_soc_pmic: Crystal Cove support

[Zhu, Lejun]

On 5/29/2014 7:49 PM, Lee Jones wrote:
> On Thu, 29 May 2014, Zhu, Lejun wrote:
> 
>> This patch provides chip-specific support for Crystal Cove. Crystal
>> Cove is the PMIC in Baytrail-T platform.
(...)
>> +enum crystal_cove_irq {
>> +	PWRSRC_IRQ = 0,
>> +	THRM_IRQ,
>> +	BCU_IRQ,
>> +	ADC_IRQ,
>> +	CHGR_IRQ,
>> +	GPIO_IRQ,
>> +	VHDMIOCP_IRQ
>> +};
> 
> I can't help thinking that these should be nice clear #defines
> 
> #define CRYSTAL_COVE_IRQ_PWSRC 		0
> ...
> #define CRYSTAL_COVE_IRQ_VHDMIOCP	6
> 

Sure. I'll fix it.

Best Regards
Lejun

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/