Re: [PATCH] staging: nokia_h4: nokia_core.c: use usleep_range() instead of msleep()

From: Greg KH
Date: Fri May 30 2014 - 11:57:48 EST


On Fri, May 30, 2014 at 11:27:13AM +0100, Miguel Oliveira wrote:
> Creating this patch for the Eudyptula Challenge.
> Replaced msleep() for a delay < 20ms with a usleep_range() between 10000us and 15000us.
> Also inserted a blank line after adeclaration.

As you are doing 2 different things in one patch, please break this up
into two different patches. Remember, each patch can only do 1 thing.

That also lets us argue about the msleep() change, while I take your
whitespace fix :)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/