Re: [PATCH] arcnet: remove check for CONFIG_SA1100_CT6001

From: David Miller
Date: Fri May 30 2014 - 20:26:20 EST


From: David Miller <davem@xxxxxxxxxxxxx>
Date: Fri, 30 May 2014 17:21:09 -0700 (PDT)

> From: Paul Bolle <pebolle@xxxxxxxxxx>
> Date: Tue, 27 May 2014 21:53:44 +0200
>
>> A check for CONFIG_SA1100_CT6001 was added in v2.6.11. But the related
>> Kconfig symbol was never added to the tree. Remove this check and do
>> some related cleaning up.
>>
>> Signed-off-by: Paul Bolle <pebolle@xxxxxxxxxx>
>
> Applied to net-next, thanks.

Reverted, you missed more references to BUS_ALIGN in com20020.c:

drivers/net/arcnet/com20020.c: In function ʽcom20020_checkʼ:
drivers/net/arcnet/com20020.c:120:22: error: ʽBUS_ALIGNʼ undeclared (first use in this function)
drivers/net/arcnet/com20020.c:120:22: note: each undeclared identifier is reported only once for each function it appears in
drivers/net/arcnet/com20020.c: In function ʽcom20020_foundʼ:
drivers/net/arcnet/com20020.c:182:35: error: ʽBUS_ALIGNʼ undeclared (first use in this function)

For a driver that builds on x86, there is no excuse not to have at least
build tested this patch.