Re: [PATCH] Staging: android: binder: Fix over-80-char lines

[Dan Carpenter]

What Neil said.

On Fri, May 30, 2014 at 10:31:20PM -0600, Daniel Dressler wrote:
> From: danieru <danieru.dressler@xxxxxxxxx>

This is wrong and we also get your name and email address from the
email headers so leave this line out.

> 
> Following Greg Kroah-Hartman's newbie guide to hacking
> the linux kernel this patch addresses only coding style
> issues.
> 
> Binder still has many too-long lines but I'm worried
> doing too much work in a single patch is unfair to the
> reviewers. So this patch address 20% of the file's
> issues.
> 
> There is one change to take notice of: it merges two if
> statement's conditionals together. Then it removes a
> redundant else clause.

Thanks for pointing this out, but the else statement wasn't redundant.
Your change introduces a bug.

Your patch doesn't apply.  You need to work against linux-next.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/