Re: [PATCH v5 02/13] mmc: mmci: convert register bits to use BIT() macro.

[Russell King - ARM Linux]

On Fri, May 30, 2014 at 06:13:00PM +0100, srinivas.kandagatla@xxxxxxxxxx wrote:
> From: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>
> 
> This patch converts the register bits in the header file to use BIT(()
> macro, which looks much neater.
> 
> No functional changes done.
> 
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>

This makes me wonder when we're going to get these definitions in the kernel
source, and have people running around making the conversion:

#define ZERO 0
#define ONE 1
#define TWO 2
#define THREE 3
#define FOUR 4
...

because allegedly it makes it more "readable".  I don't see much benefit
to this patch.

-- 
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/