Re: [PATCH] sound: pci: ice1712: wm8766.c: Cleaning up uninitialized variables

[Takashi Iwai]

At Sun,  1 Jun 2014 16:02:51 +0200,
Rickard Strandqvist wrote:
> 
> There is a risk that the variable will be used without being initialized.
> 
> This was largely found by using a static code analysis program called cppcheck.

It won't happen in reality.  And, initializing to some random values
isn't always received good.  You can use uninitialized_var() in such a
case, too.


Takashi

> 
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@xxxxxxxxxxxxxxxxxx>
> ---
>  sound/pci/ice1712/wm8766.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/pci/ice1712/wm8766.c b/sound/pci/ice1712/wm8766.c
> index 21b373b..788a31c 100644
> --- a/sound/pci/ice1712/wm8766.c
> +++ b/sound/pci/ice1712/wm8766.c
> @@ -237,7 +237,7 @@ static int snd_wm8766_ctl_get(struct snd_kcontrol *kcontrol,
>  {
>  	struct snd_wm8766 *wm = snd_kcontrol_chip(kcontrol);
>  	int n = kcontrol->private_value;
> -	u16 val1, val2;
> +	u16 val1 = 0, val2 = 0;
>  
>  	if (wm->ctl[n].get)
>  		wm->ctl[n].get(wm, &val1, &val2);
> -- 
> 1.7.10.4
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/