Re: [PATCH 1/2] spi/pxa2xx-pci: Add common clock framework support in PCI glue layer

From: Mark Brown
Date: Mon Jun 02 2014 - 08:47:49 EST


On Tue, Jun 03, 2014 at 03:46:18AM +0800, Chew Chiau Ee wrote:

> ---
> drivers/spi/spi-pxa2xx-pci.c | 20 ++++++++++++++++++++
> 1 files changed, 20 insertions(+), 0 deletions(-)

> + clk = clk_register_fixed_rate(&dev->dev, "spi_pxa2xx_clk", NULL,
> + CLK_IS_ROOT, c->max_clk_rate);
> + if (IS_ERR(clk))
> + return PTR_ERR(clk);

This is pretty much fine code wise but I'd expect to see some Kconfig
updates adding dependencies on the clock API - clk_register_fixed_rate()
is only provided if the fixed rate driver is present. I'm also not
seeing any changes to unregister the fixed rate clock as the device is
removed.

Attachment: signature.asc
Description: Digital signature