Re: [PATCH -mm] mm, compaction: properly signal and act upon lock and need_sched() contention - fix

From: Fabio Estevam
Date: Mon Jun 02 2014 - 11:18:39 EST


On Mon, Jun 2, 2014 at 11:33 AM, Vlastimil Babka <vbabka@xxxxxxx> wrote:
> compact_should_abort() returns true instead of false and vice versa
> due to changes between v1 and v2 of the patch. This makes both async
> and sync compaction abort with high probability, and has been reported
> to cause e.g. soft lockups on some ARM boards, or drivers calling
> dma_alloc_coherent() fail to probe with CMA enabled on different boards.
>
> This patch fixes the return value to match comments and callers expecations.
>
> Reported-and-tested-by: Kevin Hilman <khilman@xxxxxxxxxx>
> Reported-and-tested-by: Shawn Guo <shawn.guo@xxxxxxxxxx>
> Tested-by: Stephen Warren <swarren@xxxxxxxxxx>
> Signed-off-by: Vlastimil Babka <vbabka@xxxxxxx>

Tested-by: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/