Re: [PATCH V2] drivers/scsi/bfa/bfad_debugfs.c: replace 2 kzalloc/copy_from_user to memdup_user

[Joe Perches]

On Mon, 2014-06-02 at 19:29 +0200, Fabian Frederick wrote:
> This patch also removes unnecessary printk(KERN_INFO
[]
> diff --git a/drivers/scsi/bfa/bfad_debugfs.c b/drivers/scsi/bfa/bfad_debugfs.c
[]
> @@ -260,18 +260,10 @@ bfad_debugfs_write_regrd(struct file *file, const char __user *buf,
>  	unsigned long flags;
>  	void *kern_buf;
>  
> -	kern_buf = kzalloc(nbytes, GFP_KERNEL);
> +	kern_buf = memdup_user((void __user *)buf, nbytes);

Unnecessary cast?

[]

> @@ -336,18 +328,10 @@ bfad_debugfs_write_regwr(struct file *file, const char __user *buf,
>  	unsigned long flags;
>  	void *kern_buf;
>  
> -	kern_buf = kzalloc(nbytes, GFP_KERNEL);
> +	kern_buf = memdup_user((void __user *)buf, nbytes);

here too?


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/