Re: [PATCH] staging: ft1000: ft1000-usb: ft1000_debug.c: Fix style errors and some warnings.

[Thomas Wood]

On 06/02/2014 03:30 AM, Dan Carpenter wrote:
> On Sun, Jun 01, 2014 at 07:26:18PM -0700, Thomas Wood wrote:
>> Don't use spaces as tabs, and fix other style errors and warnings.
>>
>> Signed-off-by: Thomas Wood <tommyandrena@xxxxxxxxx>
> 
> Too much in one patch.  Break it up into one type of fix per patch and
> send a series of patches.
> 
> [patch 1] use tabs
> [patch 2] fix braces style
> [patch 3] remove parens from return values
> [patch 4] reverse an if statement
> 
> patch 3 and 4 are small enough that you could get away with pushing them
> into a single "misc fixes" patch and we wouldn't have complained but the
> first two patches are very big.
> 
> regards,
> dan carpenter
> 
> 
Ah, thank you. I will do so.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/