Re: [PATCH 06/13] perf tools: Cache dso data file descriptor

[David Ahern]

On 6/2/14, 3:18 PM, Jiri Olsa wrote:
> +static rlim_t get_fd_limit(void)
> +{
> +	struct rlimit l;
> +	rlim_t limit = 0;
> +
> +	/* Allow half of the current open fd limit. */
> +	if (getrlimit(RLIMIT_NOFILE, &l) == 0) {
> +		if (l.rlim_cur == RLIM_INFINITY)
> +			limit = l.rlim_cur;


Why not limit this to something reasonable -- 512 or 1024 -- rather 
"infinity" (~0UL).

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/