Re: [PATCH] perf, tools: Support spark lines in perf stat v5

From: Jiri Olsa
Date: Tue Jun 03 2014 - 15:47:46 EST


On Fri, May 30, 2014 at 02:42:16PM -0700, Andi Kleen wrote:
> From: Andi Kleen <ak@xxxxxxxxxxxxxxx>
>
> perf stat -rX prints the stddev for multiple measurements.
> Just looking at the stddev for judging the quality of the data
> is a bit dangerous The simplest sanity check is to just look
> at a simple plot. This patchs add a sparkline to the end
> of the measurements to make it simple to judge the data.
>
> The sparkline only uses UTF-8, so should be readable
> in all modern tools and terminals.
>
> The sparkline is between the minimum and maximum of the data,
> so it's mainly a indicator of variance. To keep the code
> simple and make the output not too wide only the first
> 8 values are printed. If more values are there it adds '..'
>
> The code is inspired by Zach Holman's spark shell script.
>
> Example output (view in non-proportial font):
>
> Performance counter stats for 'true' (10 runs):
>
> 0.175672 task-clock (msec) # 0.555 CPUs utilized ( +- 1.77% ) ââââââââ..
> 0 context-switches # 0.000 K/sec
> 0 cpu-migrations # 0.000 K/sec
> 114 page-faults # 0.647 M/sec ( +- 0.14% ) ââââââââ..
> 520,798 cycles # 2.965 GHz ( +- 1.75% ) ââââââââ..
> 433,525 instructions # 0.83 insns per cycle ( +- 0.28% ) ââââââââ..
> 83,012 branches # 472.537 M/sec ( +- 0.31% ) ââââââââ..
> 3,157 branch-misses # 3.80% of all branches ( +- 2.55% ) ââââââââ..
>
> 0.000316660 seconds time elapsed ( +- 1.78% ) ââââââââ..
>
> As you can see even in the most simple run there are quite interesting
> patterns. The time sparkline suggests it would be also useful to have an option
> to throw the first measurement away.
>
> Known issues:
> - Makes the perf stat output wider. Could be adjust by shrinking
> some white space. Not done so far.
> - No output for -A/--per-socket/--per-core with -rX. This code
> is missing the basic noise detection code. Once it's added there
> sparklines could be shown too.
>
> v2: Avoid printing spark lines for normal CSV case (Jiri)
> v3: LONG->ULONG, random changes
> v4: Add some missing changes from the forked v2: checks value is not
> zero instead of all the same. Update documentation. Remove n variable.
> Remove #pragma once
> v5: Add overflow fixes from Jiri.

got compilation error on Fedora 15 i386:

CC util/stat.o
util/stat.c: In function âprint_stat_sparkâ:
util/stat.c:91:2: error: passing argument 1 of âall_zeroâ from incompatible pointer type [-Werror]
util/stat.c:71:12: note: expected âlong unsigned int *â but argument is of type âu64 *â
util/stat.c:94:2: error: passing argument 2 of âprint_sparkâ from incompatible pointer type [-Werror]
util/spark.h:3:6: note: expected âlong unsigned int *â but argument is of type âu64 *â
cc1: all warnings being treated as errors
make[1]: *** [util/stat.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [all] Error 2


jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/