Re: [PATCH v2 2/4] tools lib traceevent: Add options to plugins

From: Jiri Olsa
Date: Wed Jun 04 2014 - 07:42:33 EST


On Tue, Jun 03, 2014 at 03:51:22PM +0900, Namhyung Kim wrote:
> On Mon, 02 Jun 2014 23:20:14 -0400, Steven Rostedt wrote:
> > +void traceevent_plugin_free_options_list(char **list)
> > +{
> > + int i;
> > +
> > + if (!list)
> > + return;
> > +
> > + if (list == (char **)((unsigned long)-1))
>
> It also should be:
>
> if (list == INVALID_PLUGIN_LIST_OPTION)
>
>
> Other than that, the series looks good to me now!

can I use your Acked-by?

thanks,
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/